From a0e4c266a10a88cae710da3c326bcebbb97235ae Mon Sep 17 00:00:00 2001
From: zhengkunwang223 <31820853+zhengkunwang223@users.noreply.github.com>
Date: Fri, 7 Apr 2023 09:16:09 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20=E8=A7=A3=E5=86=B3=E5=AE=89=E8=A3=85?=
 =?UTF-8?q?=E5=BA=94=E7=94=A8=E5=90=8C=E6=AD=A5=E4=B9=8B=E5=90=8E=E5=8F=98?=
 =?UTF-8?q?=E4=B8=BA=E5=A4=B1=E8=B4=A5=E7=9A=84=20BUG=20(#525)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 backend/app/service/app.go | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/backend/app/service/app.go b/backend/app/service/app.go
index 50b64f430..9ea51e9c9 100644
--- a/backend/app/service/app.go
+++ b/backend/app/service/app.go
@@ -249,17 +249,12 @@ func (a AppService) Install(ctx context.Context, req request.AppInstallCreate) (
 		return nil, err
 	}
 
-	paramByte, err := json.Marshal(req.Params)
-	if err != nil {
-		return nil, err
-	}
 	appInstall := model.AppInstall{
 		Name:        req.Name,
 		AppId:       appDetail.AppId,
 		AppDetailId: appDetail.ID,
 		Version:     appDetail.Version,
 		Status:      constant.Installing,
-		Env:         string(paramByte),
 		HttpPort:    httpPort,
 		HttpsPort:   httpsPort,
 		App:         app,
@@ -301,11 +296,15 @@ func (a AppService) Install(ctx context.Context, req request.AppInstallCreate) (
 	if err := copyAppData(app.Key, appDetail.Version, req.Name, req.Params); err != nil {
 		return nil, err
 	}
-
 	fileOp := files.NewFileOp()
 	if err := fileOp.WriteFile(appInstall.GetComposePath(), strings.NewReader(string(composeByte)), 0775); err != nil {
 		return nil, err
 	}
+	paramByte, err := json.Marshal(req.Params)
+	if err != nil {
+		return nil, err
+	}
+	appInstall.Env = string(paramByte)
 
 	if err := appInstallRepo.Create(ctx, &appInstall); err != nil {
 		return nil, err