From 368203443f1180be8831a7cd77f746778765d8b5 Mon Sep 17 00:00:00 2001 From: ssongliu <73214554+ssongliu@users.noreply.github.com> Date: Sat, 8 Feb 2025 22:56:57 +0800 Subject: [PATCH] fix: fix the issue of abnormal display of backup account size (#7827) --- agent/app/service/backup_record.go | 26 ++++++++-- agent/app/service/snapshot_create.go | 2 +- core/utils/cloud_storage/client/local.go | 47 ------------------- .../cloud_storage/cloud_storage_client.go | 2 - frontend/src/views/cronjob/operate/index.vue | 2 +- .../src/views/host/file-management/index.vue | 4 +- .../host/file-management/upload/index.vue | 2 +- .../host/process/process/detail/index.vue | 2 +- .../views/setting/snapshot/create/index.vue | 6 +++ frontend/src/views/toolbox/ftp/log/index.vue | 2 +- 10 files changed, 35 insertions(+), 60 deletions(-) delete mode 100644 core/utils/cloud_storage/client/local.go diff --git a/agent/app/service/backup_record.go b/agent/app/service/backup_record.go index f40c16708..47169af05 100644 --- a/agent/app/service/backup_record.go +++ b/agent/app/service/backup_record.go @@ -43,12 +43,21 @@ func (u *BackupRecordService) SearchRecordsWithPage(search dto.RecordSearch) (in if err != nil { return 0, nil, err } + accounts, _ := backupRepo.List() var data []dto.BackupRecords - for _, account := range records { + for _, record := range records { var item dto.BackupRecords - if err := copier.Copy(&item, &account); err != nil { + if err := copier.Copy(&item, &record); err != nil { global.LOG.Errorf("copy backup account to dto backup info failed, err: %v", err) } + for _, account := range accounts { + if account.ID == record.DownloadAccountID { + item.DownloadAccountID = account.ID + item.AccountName = account.Name + item.AccountType = account.Type + break + } + } data = append(data, item) } return total, data, err @@ -63,12 +72,21 @@ func (u *BackupRecordService) SearchRecordsByCronjobWithPage(search dto.RecordSe if err != nil { return 0, nil, err } + accounts, _ := backupRepo.List() var data []dto.BackupRecords - for _, account := range records { + for _, record := range records { var item dto.BackupRecords - if err := copier.Copy(&item, &account); err != nil { + if err := copier.Copy(&item, &record); err != nil { global.LOG.Errorf("copy backup account to dto backup info failed, err: %v", err) } + for _, account := range accounts { + if account.ID == record.DownloadAccountID { + item.DownloadAccountID = account.ID + item.AccountName = account.Name + item.AccountType = account.Type + break + } + } data = append(data, item) } return total, data, err diff --git a/agent/app/service/snapshot_create.go b/agent/app/service/snapshot_create.go index 06952a905..7881736ee 100644 --- a/agent/app/service/snapshot_create.go +++ b/agent/app/service/snapshot_create.go @@ -492,7 +492,7 @@ func snapUpload(snap snapHelper, accounts string, file string) error { targetAccounts := strings.Split(accounts, ",") for _, item := range targetAccounts { snap.Task.LogStart(i18n.GetWithName("SnapUploadTo", fmt.Sprintf("[%s] %s", accountMap[item].name, path.Join("system_snapshot", path.Base(file))))) - _, err := accountMap[item].client.Upload(source, path.Join("system_snapshot", path.Base(file))) + _, err := accountMap[item].client.Upload(source, path.Join(accountMap[item].backupPath, "system_snapshot", path.Base(file))) snap.Task.LogWithStatus(i18n.GetWithName("SnapUploadRes", accountMap[item].name), err) if err != nil { return err diff --git a/core/utils/cloud_storage/client/local.go b/core/utils/cloud_storage/client/local.go deleted file mode 100644 index 8df304a6a..000000000 --- a/core/utils/cloud_storage/client/local.go +++ /dev/null @@ -1,47 +0,0 @@ -package client - -import ( - "fmt" - "os" - "path" - - "github.com/1Panel-dev/1Panel/core/utils/files" -) - -type localClient struct { - dir string -} - -func NewLocalClient(vars map[string]interface{}) (*localClient, error) { - dir := loadParamFromVars("dir", vars) - return &localClient{dir: dir}, nil -} - -func (c localClient) ListBuckets() ([]interface{}, error) { - return nil, nil -} - -func (c localClient) Upload(src, target string) (bool, error) { - targetFilePath := path.Join(c.dir, target) - if _, err := os.Stat(path.Dir(targetFilePath)); err != nil { - if os.IsNotExist(err) { - if err = os.MkdirAll(path.Dir(targetFilePath), os.ModePerm); err != nil { - return false, err - } - } else { - return false, err - } - } - - if err := files.CopyFile(src, targetFilePath, false); err != nil { - return false, fmt.Errorf("cp file failed, err: %v", err) - } - return true, nil -} - -func (c localClient) Delete(file string) (bool, error) { - if err := os.RemoveAll(file); err != nil { - return false, err - } - return true, nil -} diff --git a/core/utils/cloud_storage/cloud_storage_client.go b/core/utils/cloud_storage/cloud_storage_client.go index 0292d87d2..6f693c406 100644 --- a/core/utils/cloud_storage/cloud_storage_client.go +++ b/core/utils/cloud_storage/cloud_storage_client.go @@ -14,8 +14,6 @@ type CloudStorageClient interface { func NewCloudStorageClient(backupType string, vars map[string]interface{}) (CloudStorageClient, error) { switch backupType { - case constant.Local: - return client.NewLocalClient(vars) case constant.S3: return client.NewS3Client(vars) case constant.OSS: diff --git a/frontend/src/views/cronjob/operate/index.vue b/frontend/src/views/cronjob/operate/index.vue index b6593dd70..a81bcced9 100644 --- a/frontend/src/views/cronjob/operate/index.vue +++ b/frontend/src/views/cronjob/operate/index.vue @@ -371,7 +371,7 @@ {{ $t('file.dir') }} - {{ $t('menu.file') }} + {{ $t('menu.files') }} diff --git a/frontend/src/views/host/file-management/index.vue b/frontend/src/views/host/file-management/index.vue index 40d5b7054..2f8a5128a 100644 --- a/frontend/src/views/host/file-management/index.vue +++ b/frontend/src/views/host/file-management/index.vue @@ -49,7 +49,7 @@ " /> - + - +